Optimize entry maps in TSDB doc values codec #125805
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jordan-powers
added
>non-issue
auto-backport
jordan-powers
force-pushed
the
tsdb-codec-optimize-entry-maps
branch
from
e303c94 to
9403969
Compare
|
Pinging @elastic/es-storage-engine (Team:StorageEngine) |
💔 Backport failed
You can use sqren/backport to manually backport by running |
💚 All backports created successfully
Questions ?Please refer to the Backport tool documentation |
elasticsearchmachine
pushed a commit
that referenced
this pull request
Mar 28, 2025
Currently, the Lucene90DocValuesProducer uses optimized IntObjectHashMaps to track various entries for each field, while the ES87TSDBDocValuesProducer uses regular HashMap<String, Object>. This patch updates the ES87TSDBDocValuesProducer class to also use the optimized hash maps. (cherry picked from commit 35a6298) # Conflicts: # server/src/main/java/org/elasticsearch/index/codec/tsdb/ES87TSDBDocValuesProducer.java
omricohenn
pushed a commit
to omricohenn/elasticsearch
that referenced
this pull request
Mar 28, 2025
Currently, the Lucene90DocValuesProducer uses optimized IntObjectHashMaps to track various entries for each field, while the ES87TSDBDocValuesProducer uses regular HashMap<String, Object>. This patch updates the ES87TSDBDocValuesProducer class to also use the optimized hash maps.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the
Lucene90DocValuesProduceruses optimizedIntObjectHashMapsto track various entries for each field, while theES87TSDBDocValuesProduceruses regularHashMap<String, Object>. This patch updates theES87TSDBDocValuesProducerclass to also use the optimized hash maps.